Handle Subscription Complete#52
Open
pizzapanther wants to merge 6 commits intoprodigyeducation:masterfrom
Open
Handle Subscription Complete#52pizzapanther wants to merge 6 commits intoprodigyeducation:masterfrom
pizzapanther wants to merge 6 commits intoprodigyeducation:masterfrom
Conversation
Contributor
|
@pizzapanther thanks for the contribution to the project, could you please add a unit tests for the proposed changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Handle subscription complete properly.
What is the current behavior?
Errors out when a complete message is sent.
What is the new behavior?
Return from function so subscribe complete and websocket is cleaned up.
Does this PR introduce a breaking change?
no
Other information